improvement for add_bill interface

[richcowan]

The add_bill interface would be cleaner if there were fewer buttons... the way this could be implented intuitively is to borrow from Gmail and change the 'add line item' button to a link and put it on a separate line. And, similar to the interface for airline flight searches at beta.itasoftware.com, add a link to remove line items as well if there are too many.

Here is the change to the template add_bill.tpl.html starting with line 174:

<div class="linelinks">
  <a href="javascript:void(0)" name="add" onclick="addLastLineItem();">{t}Add line item{/t}</a> |
  <a href="javascript:void(0)" name="remove" onclick="removeLineItem();">{t}Remove last line item{/t}</a>
</div>

<div class="buttons">

Also the line 278 is incorrect grammatically in english, it should read:

{t}The following tasks are associated with this invoice{/t}

This wording change might require a change in the potext files.

Finally we need a javascript function delLastLine in the file billing.js to take care of our row deletion. Here it is:

function delLastLineItem() {
    var row=document.getElementById('tbllineitems').rows.length-1
    if (row>0){document.getElementById('tbllineitems').deleteRow(row)}
    }

[florian]

I have corrected the grammar and have changed the "add line item" button to a link. The changes have been committed as revision r941. Does that look ok?

Currently each line item that is not tied to a task/operation does already have its own "delete" icon. Do you think the "Remove last line item" is necessary?

[richcowan]

Florian -

I think that "remove last line item" is more intuitive... just look at the beta.itasoftware.com guest page for adding legs to an airline trip. It is clean. It is not necessary however to have 2 different ways of doing things so implement whichever one you prefer.

-rich